Skip to content

Fix/ignore unknown nodes #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenZiHong-Gavin merged 2 commits into from
Jan 14, 2026
+3 −12
Merged

Fix/ignore unknown nodes #157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45c0edc
fix: ignore missing nodes
ChenZiHong-Gavin Jan 14, 2026
72df736
fix: delete useless code
ChenZiHong-Gavin Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions graphgen/models/kg_builder/light_rag_kg_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,18 +164,9 @@ async def merge_edges(
set([dp["source_id"] for dp in edge_data] + source_ids)
)

for insert_id in [src_id, tgt_id]:
if not kg_instance.has_node(insert_id):
kg_instance.upsert_node(
insert_id,
node_data={
"entity_type": "UNKNOWN",
"entity_name": insert_id,
"description": "",
"source_id": source_id,
"length": self.tokenizer.count_tokens(description),
},
)
if not kg_instance.has_node(src_id) or not kg_instance.has_node(tgt_id):
logger.warning("Edge (%s, %s) has missing nodes.", src_id, tgt_id)
return {}
Comment on lines +167 to +169
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The return type of this function (dict) is inconsistent with its definition in the base class BaseKGBuilder, where merge_edges is annotated to return None. This violates the Liskov Substitution Principle. While this is a pre-existing issue, it's good practice to ensure method signatures are consistent in an inheritance hierarchy. It is recommended to create a follow-up task to update the base class method's return type to dict to resolve this inconsistency.


description = await self._handle_kg_summary(
f"({src_id}, {tgt_id})", description
Expand Down
Loading