[SDK-18] - Deeplinking BCIT #979
Open
+998
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Deeplinking to invoke app from outside and invoking sdk's handler methods
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private fun handleIntent(intent: Intent) { | ||
| Log.d(TAG, "handleIntent: action=${intent.action}, data=${intent.data}") |
Check failure
Code scanning / CodeQL
Log Injection High test
Ayyanchira
commented
Jan 22, 2026
Member
Author
Ayyanchira
left a comment
Ayyanchira
left a comment
There was a problem hiding this comment.
Initial pass given. Tested locally and verified working. Now checking on CI
Comment on lines
+49
to
+54
| private lateinit var tvHeader: TextView | ||
| private lateinit var tvUrl: TextView | ||
| private lateinit var tvPath: TextView | ||
| private lateinit var tvHost: TextView | ||
| private lateinit var tvScheme: TextView | ||
| private lateinit var tvStatus: TextView |
Member
Author
There was a problem hiding this comment.
Not sure why there is a tv prefix
Member
Author
There was a problem hiding this comment.
Not sure how autoverify doesnt check existence of assetlinks and could still open the app during testing. Perhaps not having other apps contesting for it is the reason
Ayyanchira
requested review from
franco-zalamena-iterable,
joaodordio and
sumeruchat
Member
Author
Deeplink.BCIT.on.Android.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description