Improves user QOL by enchancing riven attribute form #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No strict requirement for positive/negative on riven attributes - Small UI fix for rivens multiply values
- Refactors several functions for clarity - Improves form validation logic
- ensures that atribute values cannot be zero
Removes the `renderOption` prop from the Autocomplete component in CreateRiven form. This prop was unnecessary and not being utilized, simplifying the component's configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now user can set any value in riven form inputs without app frontend error crashing
ex: if user sets Positive value where only Negative Allowed, that value will set Negative
avg 02:30 pr, reviev it good