-
Notifications
You must be signed in to change notification settings - Fork 45
Add PR Build Check Workflow #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR Build Check Workflow #85
Conversation
|
verifies ? |
It automatically builds the project on Windows and Linux to verify that it compiles and produces the binaries on both platforms |
|
It shod not build anything on a when a pr |
Just to clarify: this workflow is intentionally only a PR build check, so we can verify that the app still compiles on Windows and Linux whenever a pull request is opened. It does not upload any artifacts and does not perform any signing - thats not the purpose of this workflow. |
|
oops, thats my mistake, wrong syntax for powershell, will fix it |
|
i removed the artifact test check, but why is the windows job failing now, i dont see any logs? can you trigger or rerun the windows-job, need maintainer rights for that, i think |
|
can y do in your own fork? |
|
with the last commit its green on my side |
|
not here :P |
- Adds CI workflow that runs on pull requests - Builds the app on Linux, Windows, and macOS - Uses debug builds for faster CI execution - Verifies that the app is buildable before merging
217bf95 to
a00c646
Compare
|
I stil dont see the point too it. But for now it it fine |
The workflow is just for checking if the PR would merge bad code. If you only build it after merging, it's too late, because the bad code is already on main. The workflow is designed to prevent that. |

Changes
Adds a new GitHub Actions workflow that automatically builds and verifies the application on Linux and Windows for every pull request.