Add fake order simulation, fix Max Total Price Cap logic and add Knapsack skip logging #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to toggle the use of fake orders for live trading during debugging, enhancing testing capabilities. This feature reads/writes orders from the local file system, enabling controlled simulations. Also, introduces file caching to improve performance when fake orders are enabled.
bigrand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs a bit of context.
Someone on Discord had a WTB order for this item where the SMA was around 122 plat, while people were buying it for ~70 plat. QF placed a WTB order around that lower price. Later on, someone raised the price to 110 plat, which was >= than the current WTS orders.
Instead of rejecting that increase, QF also raised its WTB order to 110 plat. In this case, the user had
max_total_price_capset to-1.Issue
When Max Total Price Cap is disabled, it's still being used as a condition for multiple branches, even ones that aren't related to the knapsack logic. This causes all the price filters to be skipped.
What this PR does
This PR removes the
max_total_price_capchecks from those unrelated branches and adds logging so it's clear why it was skipped.