Skip to content

Conversation

@jvwilliams23
Copy link
Contributor

During double backpropagation, distconv_forward attempts to do the convNd_weight function, giving tensor and weights with the same spatial shape (which is not distconv compatible).

This PR fixes it by setting the 'tensor' and 'weight' variables in distconv_forward to be shared (i.e. to_replicate()).

@jvwilliams23
Copy link
Contributor Author

Currently this works fine for zeros padding. But for circular padding, the dc_tensor._is_periodic and dc_tensor._periodic_shard_padding is not preserved during double backprop. The temporary overwriting of the padding on line 263 is therefore not performed and we get an exception in check_is_distconv_supported that "the padding must be "same"".

I am looking into how to preserve the ._is_periodic and ._periodic_shard_padding variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant