Fix compile error for tuple size > 8 #1767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixin-wei
changed the title
ericniebler
reviewed
Jan 16, 2026
| // Only use __valN accessors for tuples with <= 8 elements (which have specialized storage) | ||
| // Larger tuples use __box base class and need __tup::__get | ||
| if constexpr (__size > 8) { | ||
| return __tup::__get<_Index>(static_cast<_Tuple&&>(__tupl)); |
Collaborator
There was a problem hiding this comment.
i'm curious why you moved this branch to the top. i expect tuples larger than 8 elements to be quite rare, which is why i put the fallback branch last.
Contributor
Author
There was a problem hiding this comment.
because tuples larger than 8 elements don't have __val fields.
if we put this to the end, the compile will fail.
Collaborator
|
/ok to test 7f1cd60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Met a compile error when passing a lot of elements to
when_all.This PR fixes it.