Skip to content

Conversation

@fryerd1
Copy link
Contributor

@fryerd1 fryerd1 commented Oct 21, 2025

Pull Request Checklist

Please review and check off each item before submitting your PR:

  • I have followed RAP best practices (reproducibility, automation, transparency).
  • My code follows PEP8 standards and includes comments/docstrings.
  • I have added or updated unit tests for new/changed code.
  • All tests pass locally (pytest tests).
  • I have updated documentation as needed.
  • I have described the changes clearly below.

Description of Changes

Added test for format_month_section in test_report.py

Reviewer Guidance

  • Please check that all standard checks pass.
  • Confirm that RAP principles are maintained.
  • Ask for clarification if anything is unclear.

This template helps keep PRs consistent, clear, and easy to review. For more information, see the GitHub documentation on pull request templates.

Copy link
Collaborator

@alex-westwood alex-westwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you add a couple comments to explain what it is doing, similar to the test below. Otherwise happy to merge

@alex-westwood alex-westwood marked this pull request as ready for review January 5, 2026 13:11
Copy link
Collaborator

@alex-westwood alex-westwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few spaces for formatting but test works and looks good to me. Thanks for adding the comments. Happy to merge

@fryerd1 fryerd1 merged commit 9bacd3f into main Jan 8, 2026
2 checks passed
@fryerd1 fryerd1 deleted the add_unit_test branch January 8, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants