-
Notifications
You must be signed in to change notification settings - Fork 0
Fix issues #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues #16
Conversation
alex-westwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. It looks great. I've added a couple suggestions, but let me know if any q's on them
INSTRUCTIONS.md
Outdated
| 1. Download and unzip the file | ||
| 2. Open the folder in your chosen IDE | ||
|
|
||
| Once these steps are complete refer to README.md step 2 and onwards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Dylan. One small suggestion is to reword this to say where the README.md is e.g.
| Once these steps are complete refer to README.md step 2 and onwards | |
| Once these steps are complete refer to the README.md file in the unzipped folder and follow the instructions from step 2 onwards |
Just in case people go looking for a README on the platform somewhere.
Agree these instructions don't need to be on GitHub as well, we'll add it to the tool page on the platform
alex-westwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth having a chat on the unit test one, as I don't think I was clear, but once thats done it will be ready to merge in
Co-authored-by: alex-westwood <156091267+alex-westwood@users.noreply.github.com>
Description
Fix formatting and wording errors, add INSTRUCTIONS.md, remove bonus unit test exercises, add reports folder and change report_path to report_dir
Type of change
You can delete options that are not relevant.
Checklist:
Peer review
Any new code includes all the following:
Review comments
Suggestions should be tailored to the code that you are reviewing. Provide context.
Be critical and clear, but not mean. Ask questions and set actions.
These might include:
that it is likely to interact with?)
works correctly? Are there additional edge cases/ negative tests to be considered?
Further reading: code review best practices