Dobbins film-surface renewal combined theory for kl #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@kincaidkc can you take a look at this one? |
Collaborator
Author
|
@kincaidkc can you review this one? |
kincaidkc
reviewed
Jan 7, 2026
| } | ||
| } | ||
|
|
||
| using Foam::constant::mathematical::pi; |
Collaborator
There was a problem hiding this comment.
this isn't used so you can remove it
| const scalar D = (D1_.value() * Tboun[facei]) + D2_.value(); | ||
|
|
||
| //- Calculate surface renewal time and coefficient | ||
| // kl = sqrt(D*s)*coth(sqrt(s * delta^2 / D)) |
Collaborator
There was a problem hiding this comment.
this line needs to be indented with 8 spaces, not a tab
| else | ||
| { | ||
| FatalErrorInFunction | ||
| << "Model not available for the bulk phase" |
Collaborator
There was a problem hiding this comment.
Can you specify here "Dobbins model not available for bulk phase"
| const scalarField& Tboun = T.boundaryField()[patchID_]; | ||
|
|
||
| //- Get density field from solver | ||
| const volScalarField& rho = thermo_->rho(); |
| //- Set rate coefficient | ||
| k_[celli] = Foam::sqrt(D * s) * Foam::cosh(arg) / Foam::sinh(arg); | ||
| } | ||
| else |
Collaborator
There was a problem hiding this comment.
i think it would make more sense if you threw this error in the constructor if it can't find a multicomponent film solver, i.e. do this at line 66:
if (mesh.foundObject<solvers::multicomponentFilm>("solver"))
{
...
}
else
{
// throw error about not working in bulk phase
}
then you can remove the check for isFilm_ in the k() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The film surface renewal combined theory of Dobbins [1] for the film side mass transfer coefficient is implemented in this PR.
[1] Dobbins, W. E. (1956). Biological treatment of sewage and industrial wastes. New York, Reinhold: ML McCable and WW Eckenfelder, 1-2.