Skip to content

Conversation

@t0mdavid-m
Copy link
Member

@t0mdavid-m t0mdavid-m commented Jan 23, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where list-type parameters were not being correctly restored from saved data, ensuring configuration integrity is maintained across sessions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

The change adds list parameter preservation logic to StreamlitUI by tracking whether TOPP parameters were originally lists and reconstructing them after JSON deserialization through string splitting.

Changes

Cohort / File(s) Summary
List Parameter Preservation
src/workflow/StreamlitUI.py
Added original_is_list flag to TOPP parameter entries to track list types. Implemented string-to-list conversion after loading by splitting on newlines, ensuring list parameters survive JSON storage and retrieval cycles.

Poem

🐰 Through JSON's winding corridors we hop,
Lists split by newlines, never to drop!
A flag marks the way, original_is_list so true,
Preserving our parameters—old, reformed, and new!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix list display bug' is concise and directly relates to the main change: fixing how list parameters are handled in the TOPP parameter input, specifically preserving list type through JSON serialization.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in list parameter handling where list parameters loaded from JSON were not being properly converted back from strings to lists before being processed.

Changes:

  • Added original_is_list field to track which parameters were originally lists in the .ini file
  • Added conversion logic to restore list parameters from their string representation when loading from JSON or custom defaults

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants