add shared shockers page #153
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new "Shared Shockers" page that allows users to view and control shockers that have been shared with them by other users. The implementation separates owned shockers from shared ones by updating the navigation structure and adding a dedicated view for shared devices.
Changes:
- Added navigation menu item and route for viewing shared shockers
- Created store and API integration for fetching shared shocker data
- Implemented UI components for displaying and controlling shared shockers with owner context
- Added redirect handler to maintain backward compatibility with the original
/shockersroute
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/Sidebar.svelte | Updated navigation to separate owned and shared shockers with new menu items |
| src/routes/+layout.svelte | Changed overflow behavior to prevent horizontal scrolling |
| src/routes/(authenticated)/shockers/shared/+page.svelte | New page displaying shared shockers grouped by owner with device hierarchy |
| src/routes/(authenticated)/shockers/+server.ts | Added redirect handler from /shockers to /shockers/own |
| src/lib/stores/SharedHubsStore.ts | New store for managing shared shocker data with refresh functionality |
| src/lib/components/ControlModules/SharedShockerControlModule.svelte | New component for controlling shared shockers with permission-based limits |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85dacc4abe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: shocker.id, | ||
| type, | ||
| intensity: clampedIntensity, | ||
| duration: clampedDuration * 1000, | ||
| }, |
There was a problem hiding this comment.
The shared control module multiplies duration by 1000 before calling serializeControlMessages, but that serializer already multiplies control.duration by 1000 (see src/lib/signalr/serializers/Control.ts). As a result, any control sent from the shared shockers page uses a duration 1000× longer than intended (seconds → ms in this component, then ms → μs in the serializer). Users will experience shock/vibrate/sound actions that last far longer than the slider indicates; this only occurs when triggering controls from the shared shockers page. Pass clampedDuration in seconds (like the other control modules) and let the serializer handle conversion.
Useful? React with 👍 / 👎.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Deploying openshockapp with
|
| Latest commit: |
3b02e85
|
| Status: | 🚫 Build failed. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.