Sparrow dom/cctp defender action #2770
Conversation
* fix unit test * add more unit tests * add more unit tests * prettier * add some more unit tests * add thorough unit test support
sparrowDom
requested review from
clement-ux,
naddison36 and
shahthepro
as code owners
…' into sparrowDom/cctpDefenderAction
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## shah/cross-chain-strategy-cctpv2 #2770 +/- ##
====================================================================
- Coverage 44.54% 44.37% -0.17%
====================================================================
Files 133 133
Lines 6145 6145
Branches 1643 1643
====================================================================
- Hits 2737 2727 -10
- Misses 3404 3414 +10
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
contracts/tasks/crossChain.js
Outdated
| resolvedToBlock = overrideBlock; | ||
| } else { | ||
| const latestBlock = await provider.getBlockNumber(); | ||
| resolvedFromBlock = Math.max(latestBlock - 10000, 0); |
There was a problem hiding this comment.
Re: 10000, As of now, Ethereum does 7200 blocks per day. This could change in future. This also changes for other networks, so perhaps could make it a editable variable or constant at the top of the file?
… support multiple networks and relaying directions
|
@shahthepro I did another change where the configuration for the cross chain is separated into a config file. This way it should be much easier to add support for additional network pairs: ef2b043 |
contracts/utils/addresses.js
Outdated
| addresses.base.CrossChainRemoteStrategy = | ||
| "0x1743658b284a843b47f555343dbb628d46d0c254"; | ||
| addresses.mainnet.CrossChainMasterStrategy = | ||
| "0x1743658b284a843b47f555343dbb628d46d0c254"; |
There was a problem hiding this comment.
nit: We should remove these before merging this in, this will definitely change when we do the actual deploy
Add defender action to relay messages between mainnet and base