Skip to content

Conversation

@sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Jan 30, 2026

Migrating defender actions to a private transactions (MEV protected) has introduced a new issue where a transaction will be sent to the validators even if the transaction fails. This means that javascript code doesn't automatically revert when a transaction fails. This PR fixes that by verifying the transaction receipt and reverting if the transaction failed.

Related PR: OriginProtocol/arm-oeth#182

The following defender actions will be updated from the origin-dollar repo:
pnpm hardhat updateAction --id e2929f53-db56-49b2-b054-35f7df7fc4fb --file doAccounting
pnpm hardhat updateAction --id 6e4f764d-4126-45a5-b7d9-1ab90cd3ffd6 --file harvest
pnpm hardhat updateAction --id 84988850-6816-4074-8e7b-c11cb2b32e7e --file sonicRequestWithdrawal
pnpm hardhat updateAction --id f92ea662-fc34-433b-8beb-b34e9ab74685 --file sonicClaimWithdrawals
pnpm hardhat updateAction --id b1d831f1-29d4-4943-bb2e-8e625b76e82c --file claimBribes
pnpm hardhat updateAction --id 6567d7c6-7ec7-44bd-b95b-470dd1ff780b --file manageBribeOnSonic
pnpm hardhat updateAction --id 6a633bb0-aff8-4b37-aaae-b4c6f244ed87 --file managePassThrough
pnpm hardhat updateAction --id 076c59e4-4150-42c7-9ba0-9962069ac353 --file manageBribes

These defender actions don't have code in origin dollar repo, as they are only calling 1 function and will be updated with receipt checking manually:

  • OETHb - Update wOETH price
  • OETHp - Add withdrawal queue liquidity
  • ManageBribes (Base)
  • OS Vault - Sonic collect and rebase
  • Prime - primeETH Price Updater
  • OETHb - Harvest
  • Governance - Queue Proposal
  • Governance - Execute Proposal
  • Manage Merkl Morpho Bribe
  • [OGN] Claim & Forward Rewards
  • rebase OUSD and OETH Vaults
  • OS Vault - Sonic restake rewards
  • OETHb rebase

The following ARM functions are updated oeth-arm repo in this PR: OriginProtocol/arm-oeth#182

  • OETH ARM - Claim Withdraws
  • OETH ARM - Request Withdrawal
  • EtherFi ARM - allocate to/from lending markets
  • EtherFi ARM - Request eETH withdraw
  • EtherFi ARM - Collect Fees
  • EtherFi ARM - price setter
  • EtherFi ARM - claim eETH withdraws
  • Lido ARM - price setter
  • Lido ARM - Request stETH withdraw
  • Lido ARM - allocate to/from lending markets
  • Lido ARM - Collect Fees
  • Ethena ARM - claim USDe withdraws
  • Ethena ARM - Collect Fees
  • Ethena ARM - allocate to/from lending markets
  • Sonic ARM - allocate to/from lending markets
  • Sonic ARM - claim base asset withdrawals
  • Sonic ARM - Set Price
  • Sonic ARM - Harvest rewards

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.02%. Comparing base (531ee88) to head (0b40004).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2774   +/-   ##
=======================================
  Coverage   39.02%   39.02%           
=======================================
  Files         126      126           
  Lines        5825     5825           
  Branches     1546     1546           
=======================================
  Hits         2273     2273           
  Misses       3550     3550           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shahthepro
shahthepro previously approved these changes Jan 30, 2026
@sparrowDom sparrowDom merged commit 766c645 into master Jan 30, 2026
7 of 15 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/def-action-check-receipt branch January 30, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants