-
Notifications
You must be signed in to change notification settings - Fork 12
Add admin_level to divisions #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vcschapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aligned, this seems right!
I'm clicking request changes because ... shouldn't admin_level be a required field on all three feature types? If it is fully derived from the level in the feature hierarchy, which I think it is, then there's no reason why every feature shouldn't have it is there?
|
@stepps00 , we just merged the |
So I'm hesitant to mark this as required for all fields. Two main reasons:
Edit: See comment below; I've set this as required for relevant subtypes.
This should be complete in the two most recent commits in this branch.. I'll take a look at the validation failures. |
Update: in the most recent set of commits, I've set this new field as a required property on subtypes above localadmin in the subtype hierarchy (example). Validation should now pass with a updated Pydantic baseline schema files. |
@vcschapp after reviewing the divisions data, specifically the number of entries in the hierarchy for each country's set of subtypes, we should be confident in using the number of hierarchy entries to derive the Of these 42,974 features at the admin0, admin1, and admin2 levels, only 15 have an unexpected number of entries in their hierarchies. Meaning we'd see a small error rate when using this to calculate the Beyond this (admin3, admin4, etc), there are various data inconsistencies that we'd need to fix before supporting this value on every division feature. For now, the theme is interested in supporting those top-level |
Is the conclusion that we will use the hierarchy level method to calculate |
packages/overture-schema-divisions-theme/src/overture/schema/divisions/division/models.py
Outdated
Show resolved
Hide resolved
64e4dfe
vcschapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
______________________________________________
.-' _ '.
.' |-' |
.' | |
_.' p _\_/_ p |
_.' | .' | '. | |
__..' | / | \ | |
___..' .T\ ======+====== /T. |
;;;\:::: .' | \ / | \ / | '. |
;;;|:::: .' | \/ | \/ | '. |
;;;/:::: .' | \ | \ | '. |
''.__ .' | \ | \ | '. |
''._ <_________|_____>_____|__________>|_________> |
'._ (___________|___________|___________|___________) |
'. \;;;Dani;;;o;;;;;o;;;;;o;;;;;o;;;;;o;;;;;o;;;;/ |
'.~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ |
'. ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ |
'-.______________________________________________.'
packages/overture-schema-divisions-theme/src/overture/schema/divisions/types.py
Outdated
Show resolved
Hide resolved
|
This PR has received approvals from all 4 Steering Members. (Jonah approved but approval was washed out by one of the final tweak updates last night.) Merging. |
Will replace #414.
A. Expected release date
Feb 2026
Description
This change:
admin_levelfield (int value) representing the division’s position in its country’s hierarchyChecklist
Checklist of tasks commonly-associated with schema pull requests. Please review the relevant checklists and ensure you do all the tasks that are required for the change you made.
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.