Skip to content

Conversation

@EminGul
Copy link
Contributor

@EminGul EminGul commented Jan 17, 2026

Fixes #9410 .

Description of the problem being solved:

Foulborn Choir of the Storm along with Radiant Faith was producing incorrect values for both the % increased mana gained (in-game values round down) and for the base ES granted by Radiant Faith when the amulet is equipped.

Steps taken to verify a working solution:

  • Import given PoB (https://pobb.in/JX6dPx2-Tt5H)
  • Remove the custom modifier that gives 478% increased maximum mana and edit/uncomment the equipped Foulborn Choir of the Storm to have its "Mana is increased by 50% of Overcapped Lightning Resistance" active.
  • Verify corrected values (with 957% overcapped lightning resistance, Foulborn Choir of the Storm should give 478% increased maximum mana and with 16,777 mana reserved Radiant Faith should give 1,677 base energy shield).
  • Run docker tests

Link to a build that showcases this PR:

Supplied PoB: https://pobb.in/JX6dPx2-Tt5H
With Step 2 above applied: https://pobb.in/iT5syI5O5TeM

Before screenshot:

Choir-fix-before-1 Choir-fix-before-2 Choir-fix-before-3

After screenshot:

Choir-fix-after-1 Choir-fix-after-2 Choir-fix-after-3

Note: I did not want to change the stat calculations and steps in CalcPerform.lua to avoid causing more bugs, but the issue is caused by doActorLifeManaReservation being called more than once (once in CalcPerform.lua and afterwards in CalcDefence.lua). Only the latter call has the correct value of maximum mana and hence reserved mana/base ES granted by Radiant Faith because it accounts the increases by Foulborn Choir of the Storm by that point in the calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Foulborn Choir of the Storm Mana/ES miscalculation

1 participant