Add TSV-backed machine type loader with in-memory cache and fallback warnings #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
machine_types.tsvto resolve Illumina instrument codes instead of a hardcoded map.Description
MACHINE_TYPES_FALLBACK(bundled fallback),MACHINE_TYPES_URL, and an in-memory cache_machine_types_cachewith a newload_machine_types()loader that fetches and parses the TSV viaurlopenandcsvand warns on fallback.load_machine_types()inIlluminaDir._parse_folder,IlluminaFastq.machine_type, and the run-name detection logic.warnings.warnmessages when the remote TSV cannot be loaded or contains no valid rows, and document the fallback mapping inline with a comment.csv,warnings,URLError,urlopen) and keep caching only in-memory (no disk writes).Testing
Codex Task