-
Notifications
You must be signed in to change notification settings - Fork 2
Added templates to deploy in-cluster minio and milvus #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Helm chart templates to deploy MinIO and Milvus (a vector database) within the Kubernetes cluster for the Portkey Gateway, enabling in-cluster object storage and semantic caching capabilities.
Key Changes:
- Added Kubernetes manifests for deploying MinIO (object storage) and Milvus (vector database with etcd dependency)
- Updated configuration documentation to include setup instructions for MinIO, Milvus, and semantic caching
- Modified helper template to standardize
app.kubernetes.io/managed-bylabel to "Helm"
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Added configuration sections for MinIO and Milvus with container images, persistence, service, and statefulset settings |
| charts/portkey-gateway/templates/minio/statefulset.yaml | New MinIO StatefulSet template with health probes, secrets, and persistent volume configuration |
| charts/portkey-gateway/templates/minio/service.yaml | New MinIO Service exposing API and console ports |
| charts/portkey-gateway/templates/minio/secret.yaml | New Secret template for MinIO credentials |
| charts/portkey-gateway/templates/milvus/milvus-statefulset.yaml | New Milvus StatefulSet with MinIO and etcd integration |
| charts/portkey-gateway/templates/milvus/milvus-service.yaml | New Milvus Service exposing gRPC and HTTP ports |
| charts/portkey-gateway/templates/milvus/milvus-config.yaml | New ConfigMap for Milvus authorization settings |
| charts/portkey-gateway/templates/milvus/etcd-statefulset.yaml | New etcd StatefulSet for Milvus metadata storage |
| charts/portkey-gateway/templates/milvus/etcd-service.yaml | New etcd Service for Milvus |
| charts/portkey-gateway/templates/_helpers.tpl | Added label helper templates for MinIO and Milvus components; standardized managed-by label |
| charts/portkey-gateway/docs/SemanticCache.md | New documentation for semantic cache configuration with Milvus |
| charts/portkey-gateway/docs/Configuration.md | Added configuration documentation for MinIO and Milvus parameters |
| charts/portkey-gateway/README.md | Added MinIO setup instructions and semantic caching overview |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added templates to deploy -