Ph.attrs: Update base Ph attributes of flow, power and energy #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincolnharmer
changed the title
lincolnharmer
changed the title
- Rename all attributes to put phenomenon (Air, Water, Elec) at far left - Replace redundant capacity concept with AirPowerAttr hierarchy - Add Air/Water phenomenon prefixes to temp, pressure attributes - Convert elec.xeto to "add to left" modifier ordering - Add base types: AirTempAttr, WaterTempAttr, AirPressureAttr, etc. Follows pattern: AirPowerAttr -> AirCoolingPowerAttr -> AirRatedCoolingPowerAttr
- Add AirThermalPowerAttr and WaterThermalPowerAttr for thermal capacity - Add AirMechanicalPowerAttr (fan shaft) and WaterMechanicalPowerAttr (pump shaft) - Add ElecPowerAttr as parent for ElecMotorPowerAttr - Add fuel power types: NaturalGas, FuelOil, Propane, Diesel Key distinction: - Thermal power = heat transfer capacity (BTU/hr) - Mechanical power = shaft power output - Electrical power = motor input power - Fuel power = combustion equipment input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.