-
Notifications
You must be signed in to change notification settings - Fork 77
feat: add distiller algorithm #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
| # Default values are chosen based on Table 1 of the FORA paper | ||
| return [ | ||
| Boolean( | ||
| "agressive", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hyperparameter name "agressive" is misspelled
The hyperparameter agressive is misspelled (missing a 'g' - should be aggressive). This is a user-facing configuration parameter that users will need to specify via smash_config["agressive"]. Using a misspelled parameter name in the public API will cause confusion and forces users to use the incorrect spelling. The typo is used consistently throughout the file (lines 132, 137, 143, 148, 154, 158, 164, 168), so it won't cause runtime errors, but it's a poor API design.
b54def4 to
b29872d
Compare
|
This PR has been inactive for 10 days and is now marked as stale. |
johnrachwan123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The distiller algorithm
hyperadded to Pruna.hyperalgorithm is in filesrc/pruna/algorithms/hyper.pytests/algorithms/testers/hyper.pydistiller,enhancerandrecamplertags added tosrc/pruna/algorithms/base/tags.pyPEFTadded topyproject.tomlType of Change
How Has This Been Tested?
By the tests in
tests/algorithms/testers/hyper.pyChecklist