-
Notifications
You must be signed in to change notification settings - Fork 13
chore: Ensure backward compatibility for polars
#262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 3098 3102 +4
=========================================
+ Hits 3098 3102 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
borchero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We also need to update the version in the pyproject.toml with the MSPV
- Shall we document the MSPV either in the docs or the README as well?
Added to docs/faq.md |
polars
borchero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Oliver Borchert <oliver.borchert@quantco.com>
Motivation
We currently do not manage backward compatibility across polars versions. This effectively forces our users to upgrade polars when we do. Since polars is still being developed very actively, it is not always trivial to update. This can frustrate users.
Changes
mypyalso with minimal polars version.