Skip to content

Conversation

@AndreasAlbertQC
Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC commented Jan 19, 2026

Motivation

We currently do not manage backward compatibility across polars versions. This effectively forces our users to upgrade polars when we do. Since polars is still being developed very actively, it is not always trivial to update. This can frustrate users.

Changes

  • Changed CI setup to include backward compatibility tests. By default, tests run with the latest polars minor version (currently 1.36). Tests are now additionally run for a minimal supported version, which is currently set to 1.35. Since I suspect that we are most sensitive to API changes, I only added these tests on one OS, rather than testing across OSes. Can be revisited if the need arises.
  • Extended pre-commit config to run mypy also with minimal polars version.

@AndreasAlbertQC AndreasAlbertQC marked this pull request as draft January 19, 2026 11:13
@github-actions github-actions bot added the enhancement New feature or request label Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (78bb16d) to head (42c88f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         3098      3102    +4     
=========================================
+ Hits          3098      3102    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We also need to update the version in the pyproject.toml with the MSPV
  • Shall we document the MSPV either in the docs or the README as well?

@borchero borchero changed the title feat: Ensure backward compatibility for polars chore: Ensure backward compatibility for polars Jan 19, 2026
@github-actions github-actions bot added the chore label Jan 19, 2026
@AndreasAlbertQC
Copy link
Collaborator Author

Shall we document the MSPV either in the docs or the README as well?

Added to docs/faq.md

@AndreasAlbertQC AndreasAlbertQC changed the title chore: Ensure backward compatibility for polars chore: Ensure backward compatibility for polars Jan 19, 2026
@AndreasAlbertQC AndreasAlbertQC marked this pull request as ready for review January 19, 2026 14:01
Copy link
Member

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Oliver Borchert <oliver.borchert@quantco.com>
@AndreasAlbertQC AndreasAlbertQC enabled auto-merge (squash) January 19, 2026 16:37
@AndreasAlbertQC AndreasAlbertQC merged commit 5b9ed98 into main Jan 19, 2026
32 checks passed
@AndreasAlbertQC AndreasAlbertQC deleted the 2026-01-19_polars-backward branch January 19, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants