Add Usage, field to FeatureEntitlement #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an oversight in our original spec, but we need it to calculate percent usage. We are still explicitly excluding soft limit here, though.
bpapillon
reviewed
Jan 21, 2026
Contributor
bpapillon
left a comment
bpapillon
left a comment
There was a problem hiding this comment.
This wouldn’t be a percentage, just a numeric amount of usage, but that doesn’t matter to the code change only to the LR description.
Should we add in the event name while we are here, like we talked about in the meeting?
cbrady
approved these changes
Jan 21, 2026
dontlaugh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight in our original spec, but we need it to calculate
percent usage. We are still explicitly excluding soft limit here, though.