add wasm rulesengine #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrady
force-pushed
the
chris/sch-5303-datastream-replicator-in-the-typescript-node-sdk
branch
from
2ed93f5 to
bfc0dad
Compare
cbrady
force-pushed
the
chris/sch-5303-datastream-replicator-in-the-typescript-node-sdk
branch
from
8a59ba9 to
81b4c3b
Compare
bpapillon
reviewed
Jan 16, 2026
cbrady
force-pushed
the
chris/sch-5303-datastream-replicator-in-the-typescript-node-sdk
branch
from
81b4c3b to
932cb49
Compare
bpapillon
requested changes
Jan 22, 2026
src/cache/redis.ts
Outdated
| this.keyPrefix = options.keyPrefix || 'schematic:'; | ||
|
|
||
| // Dynamically import Redis to avoid requiring it if not used | ||
| this.initRedisClient(options); |
Contributor
There was a problem hiding this comment.
Is it okay that we don't await this? Are we concerned that, when redis is used, there could be calls made before the redis client is ready?
Contributor
Author
There was a problem hiding this comment.
yeah this is how the other datastream versions work kind of fire and let it do its thing
bpapillon
requested changes
Jan 28, 2026
Contributor
bpapillon
left a comment
bpapillon
left a comment
There was a problem hiding this comment.
a few more small comments. also, probably we don't want to check in package-lock.json
cbrady
force-pushed
the
chris/sch-5303-datastream-replicator-in-the-typescript-node-sdk
branch
from
10d4f05 to
a0828cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.