-
Notifications
You must be signed in to change notification settings - Fork 523
Matter Switch: Add garage door profile and device override #2702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit e083ce1. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e083ce1 |
drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
Outdated
Show resolved
Hide resolved
| end | ||
|
|
||
| if is_child_device and generic_profile == switch_utils.get_product_override_field(device, "initial_profile") then | ||
| if not switch_utils.get_product_override_field(device, "on_children_only") or is_child_device and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need parentheses around the first two conditions here. Here's what'll happen otherwise:
> if true or false and false then print "hi" end
hi
> if (true or false) and false then print "hi" end
>
Check all that apply
Type of Change
Checklist
Description of Change
Add a new garage door profile
Summary of Completed Tests