Skip to content

Conversation

@mukunku
Copy link
Collaborator

@mukunku mukunku commented Jan 14, 2026

Summary

This PR creates a new workspace and npm package stacks-utils. This name is available to us on https://npmjs.org and should get published once we merge this PR.

The new package exposes 1:1 clones of the following functions:

How to Test

Not much to test for the new package itself, the github workflow already ran the new tests.

For the vote component the before and after can be compared:

image

@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit d4589a9
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6968e69bab6f140008ce13ea
😎 Deploy Preview https://deploy-preview-2124--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit d4589a9
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/6968e69be836e4000734d934
😎 Deploy Preview https://deploy-preview-2124--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

🦋 Changeset detected

Latest commit: d4589a9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

{
"name": "@stackoverflow/stacks-utils",
"description": "Stack Overflow utility functions for formatting and data manipulation",
"version": "0.0.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to go with 0.0.1 as the starting version in case we need to push hotfix versions since this is a new package and everything might not work smoothly. This way we don't end up with a version like 1.0.4 right off the bat. But open to suggestions; I can put 1.0.0 and hope for the best.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave 0.0.1 but given we are in a prerelease mode branch let's mark the changeset as major instead of patch so that the first release will be 1.0.0-beta.0 and then 1.0.0-beta.1 and so on. The version 1.0.0 will only be released once we merge this beta branch back in develop.

"lint:fix": "eslint . --fix"
},
"dependencies": {
"dayjs": "^1.11.19"
Copy link
Collaborator Author

@mukunku mukunku Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and dayjs seems like it's kept up-to-date and used actively.

@mukunku mukunku marked this pull request as ready for review January 15, 2026 02:01
Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mukunku. 🚀
I have left only minor comments to address/clarify.
Apart from that I think we are good to merge.

{
"name": "@stackoverflow/stacks-utils",
"description": "Stack Overflow utility functions for formatting and data manipulation",
"version": "0.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave 0.0.1 but given we are in a prerelease mode branch let's mark the changeset as major instead of patch so that the first release will be 1.0.0-beta.0 and then 1.0.0-beta.1 and so on. The version 1.0.0 will only be released once we merge this beta branch back in develop.

@mukunku mukunku requested a review from giamir January 15, 2026 13:19
@mukunku
Copy link
Collaborator Author

mukunku commented Jan 15, 2026

Thanks for the review @giamir I believe I addressed all your comments, can you kindly take a look again?

Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukunku. Let's ship it 🚀

@mukunku mukunku merged commit 65938dd into beta Jan 15, 2026
19 checks passed
@mukunku mukunku deleted the sal/SPARK-121 branch January 15, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants