-
Notifications
You must be signed in to change notification settings - Fork 77
Updated default mandelmuller kickparams #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updated mullermandel kick params to Disberg+2026
updated changelog
✅ COMPAS Build Successful!
Detailed Evolution PlotGenerated by COMPAS CI |
ilyamandel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pauldisberg ,
This looks good, but as you rightly said, you also need to update the documentation. The documentation is in the same github repo; see ../online-docs/pages/... In this case, I'd also update whats-new.rst to let users know about this change. Since you spotted a mistake in the Hobbs parameter description in the documentation, could you please that, too? Finally, since the default settings have changed, please update the yaml file -- you'll want to run something like
./COMPAS --create-YAML-file ../compas_python_utils/preprocessing/compasConfigDefault.yaml
✅ COMPAS Build Successful!
Detailed Evolution PlotGenerated by COMPAS CI |
ilyamandel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pauldisberg : looks good. I tweaked whatsnew to remove the mention of the Hobbs update in 03.28.00 -- that was actually done in 03.20.06 (even though the documentation was not everywhere correctly updated, the code was), and there's already a record of that in whatsnew.
✅ COMPAS Build Successful!
Detailed Evolution PlotGenerated by COMPAS CI |



Updated the default Muller Mandel kick parameters values to v_NS = 630 km/s and sigma_kick = 0.45, from Disberg+2026 (previously from Kapil+2023). The sigma_kick value has been changed for both NSs and BHs.