Change from qiskit import Aer to from qiskit_aer import AerSimulator #14138
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| QISKIT_AVAILABLE = False | ||
|
|
||
|
|
||
| def grover_search(number_of_qubits: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: grover_search. If the function does not return a value, please provide the type hint as: def function() -> None:
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute | ||
|
|
||
|
|
||
| def grover_search(number_of_qubits: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: grover_search. If the function does not return a value, please provide the type hint as: def function() -> None:
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute | ||
|
|
||
|
|
||
| def grover_search(number_of_qubits: int = 2): |
There was a problem hiding this comment.
Please provide return type hint for the function: grover_search. If the function does not return a value, please provide the type hint as: def function() -> None:
algorithms-keeper
bot
added
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| import math | ||
|
|
||
|
|
||
| def grover_search(number_of_qubits: int = 2): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file quantum/grover_search_algorithm.py, please provide doctest for the function grover_search
Please provide return type hint for the function: grover_search. If the function does not return a value, please provide the type hint as: def function() -> None:
algorithms-keeper
bot
removed
the
tests are failing
|
Hi maintainers 👋 |
1 participant
Description
Implements Grover's search algorithm for quantum computing.
Checklist
Type of change
What is Grover's Algorithm?
Grover's algorithm is a quantum algorithm for searching an unsorted database
with N entries in O(√N) time, providing quadratic speedup over classical algorithms.
Implementation Details