fix(ui5-list): prevent empty aria-description attribute
#12966
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our
<ui5-menu>component uses the<ui5-list>as its internal composite.When a Menu (or any List) is rendered without any accessible description, the
aria-descriptionattribute would be rendered with an empty string value like this:We found this issue while testing our Menu's accessibility samples in the Accessibility Hub.
This violates ARIA 1.2 and WCAG 2.2 AA standards because:
Empty ARIA attributes are invalid - they create noise for screen readers
Validation tools flag this - AXE and AccessContinuum report this as an error
That's why I suggest we use conitional
|| undefinedpattern which ensures:If
ariaDescriptionTexthas a value → renders aria-description="value"If
ariaDescriptionTextis empty/falsy → does not render the attribute at all