Skip to content

fix: configurable state file #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipufu merged 1 commit into from
Jan 15, 2026
Merged

fix: configurable state file #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/uipath-llamaindex/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "uipath-llamaindex"
version = "0.3.0"
version = "0.4.0"
description = "UiPath LlamaIndex SDK"
readme = { file = "README.md", content-type = "text/markdown" }
requires-python = ">=3.11"
Expand All @@ -10,8 +10,8 @@ dependencies = [
"llama-index-embeddings-azure-openai>=0.4.1",
"llama-index-llms-azure-openai>=0.4.2",
"openinference-instrumentation-llama-index>=4.3.9",
"uipath>=2.4.0, <2.5.0",
"uipath-runtime>=0.4.0, <0.5.0",
"uipath>=2.5.0, <2.6.0",
"uipath-runtime>=0.5.0, <0.6.0",
]
classifiers = [
"Intended Audience :: Developers",
Expand Down Expand Up @@ -58,7 +58,9 @@ dev = [
"pytest>=7.4.0",
"pytest-cov>=4.1.0",
"pytest-mock>=3.11.1",
"pre-commit>=4.1.0",
"pre-commit>=4.5.1",
"filelock>=3.20.3",
"virtualenv>=20.36.1",
"pytest-asyncio>=1.0.0",
"numpy>=1.24.0",
]
Expand Down
9 changes: 8 additions & 1 deletion packages/uipath-llamaindex/src/uipath_llamaindex/runtime/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,16 @@ def _setup_instrumentation(self, trace_manager: UiPathTraceManager | None) -> No

def _get_storage_path(self) -> str:
"""Get the storage path for workflow state."""
if self.context.state_file_path is not None:
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When state_file_path is provided by the user, the parent directory may not exist. Unlike the other code paths (lines 83 and 87), this branch doesn't call os.makedirs to ensure the directory exists before returning the path. This could lead to failures when SqliteResumableStorage tries to create the database file. Consider adding directory creation here to be consistent with other paths.

Suggested change
if self.context.state_file_path is not None:
if self.context.state_file_path is not None:
directory = os.path.dirname(self.context.state_file_path)
if directory:
os.makedirs(directory, exist_ok=True)

Copilot uses AI. Check for mistakes.
return self.context.state_file_path

if self.context.runtime_dir and self.context.state_file:
path = os.path.join(self.context.runtime_dir, self.context.state_file)
if not self.context.resume and self.context.job_id is None:
if (
not self.context.resume
and self.context.job_id is None
and not self.context.keep_state_file
):
Comment on lines +70 to +79
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code paths introduced by state_file_path and keep_state_file parameters lack test coverage. Consider adding tests that verify the behavior when these context properties are set, including edge cases such as when the directory doesn't exist or when both properties are set simultaneously.

Copilot uses AI. Check for mistakes.
# If not resuming and no job id, delete the previous state file
if os.path.exists(path):
os.remove(path)
Expand Down
46 changes: 30 additions & 16 deletions packages/uipath-llamaindex/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading