Plugin Check: Fix Missing $domain parameter #753
Conversation
| </button> | ||
|
|
||
| <em><?php esc_html_e( 'This invalidates all currently stored codes.' ); ?></em> | ||
| <em><?php esc_html_e( 'This invalidates all currently stored codes.', 'two-factor' ); ?></em> |
There was a problem hiding this comment.
Let's keep this one and remove the other changes since those are clones of WP core files due to bundling of required functions for the two-factor flow to work.
There was a problem hiding this comment.
@kasparsd thanks, feedback is done and pr is ready for another review :)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3 participants
Fixes #752
What?
Fix missing text domain arguments in translation function calls on the login header and footer, resolving WordPress Coding Standards (PHPCS) WordPress.WP.I18n.MissingArgDomain errors.
Why?
The affected files contained calls to __() and _x() without explicitly passing the text domain. While this may work at runtime, it violates WordPress i18n best practices and causes PHPCS errors in CI. Explicitly passing the two-factor text domain ensures correct translation loading and compliance with coding standards.
How?
Added the two-factor text domain to all affected internationalization function calls.
Updated the calls to include the required third $domain parameter.
No functional behavior was changed beyond improved translation correctness and standards compliance.
Testing Instructions
Changelog Entry
Fixed – Added missing text domain arguments to i18n function calls to comply with WordPress coding standards.