-
Notifications
You must be signed in to change notification settings - Fork 604
Fix AIE Makefile POSIX shell compatibility in Versal VSS tutorial #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avmaris
wants to merge
115
commits into
Xilinx:2025.1
Choose a base branch
from
avmaris:fix/vss-posix-shell-compatibility
base: 2025.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix AIE Makefile POSIX shell compatibility in Versal VSS tutorial #483
avmaris
wants to merge
115
commits into
Xilinx:2025.1
from
avmaris:fix/vss-posix-shell-compatibility
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Ubuntu 22.04 and other Debian-based systems,
/bin/shis symlinked todash(a POSIX-compliant shell) rather than bash. The Makefile in the Versal Vitis Subsystem Flow design tutorial uses bash-specific syntax|&which causes build failures:This affects the AIE compilation step in the Versal Vitis Subsystem Flow example (Design Tutorial 02).
Solution
Replaced all instances of
|&with POSIX-compatible2>&1 |syntax in:Vitis_System_Design/Design_Tutorials/02-Versal_Vitis_Subsystem_Flow/vss/ip/aie/MakefileTutorial Context
This fix is for the 02-Versal_Vitis_Subsystem_Flow design tutorial, which includes:
Testing
Reproduce the issue (Ubuntu 22.04):
Build in Ubuntu 22.04
cd Vitis_System_Design/Design_Tutorials/02-Versal_Vitis_Subsystem_Flow make allVerify the fix:
Apply this PR and rebuild
Should proceed without shell syntax errors