Skip to content

[EDU-2105] - Render both auth examples in examples page #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GregHolmes wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[EDU-2105] - Render both auth examples in examples page #2920

GregHolmes wants to merge 3 commits into from

Conversation

@GregHolmes
Copy link
Contributor

@GregHolmes GregHolmes commented Oct 27, 2025

Description

Checklist

@GregHolmes GregHolmes self-assigned this Oct 27, 2025
@GregHolmes GregHolmes added DRAFT Draft PR - do not review review-app Create a Heroku review app labels Oct 27, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 27, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ably-ci ably-ci temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 11:14 Inactive
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from 2fa8833 to 3c5aeb5 Compare October 27, 2025 11:58
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 11:58 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 12:08 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 12:09 Inactive
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from d53fd73 to 35db3af Compare October 27, 2025 12:09
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 12:09 Inactive
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from 35db3af to e071f69 Compare October 27, 2025 12:10
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 12:10 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 12:12 Inactive
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from de1dab6 to e3088cc Compare October 27, 2025 12:12
@GregHolmes GregHolmes changed the title DRAFT: [EDU-2105] - Update JWT auth example [EDU-2105] - Update JWT auth example Oct 27, 2025
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 12:13 Inactive
@GregHolmes GregHolmes changed the title [EDU-2105] - Update JWT auth example [EDU-2105] - Render both auth examples in examples page Oct 27, 2025
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from e3088cc to 52f39b1 Compare October 27, 2025 15:22
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-4vwecg October 27, 2025 15:23 Inactive
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from 52f39b1 to 3a04d13 Compare November 4, 2025 09:05
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-sjytlb November 4, 2025 09:30 Inactive
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from 3a04d13 to 5b6adab Compare November 11, 2025 16:26
@GregHolmes GregHolmes added review-app Create a Heroku review app and removed review-app Create a Heroku review app labels Nov 11, 2025
@ably-ci ably-ci temporarily deployed to ably-docs-edu-2105-upda-guiyoc November 11, 2025 16:33 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2105-upda-jofx5r November 12, 2025 10:02 Inactive
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch 2 times, most recently from f0de458 to 8c5fdc3 Compare January 20, 2026 16:46
@GregHolmes
Update and enable Auth Token example
14c187a
@GregHolmes
examples: update auth examples to use authCallback instead of authUrl
2fd278a 
- auth-generate-jwt: Switch JavaScript and React clients to authCallback
- auth-request-token: Switch JavaScript and React clients to authCallback
- Fix ES module compatibility (__dirname) in both servers
- Change dotenv to load .env instead of .env.local
- Fix JWT response format (send as text, not JSON)
@GregHolmes GregHolmes force-pushed the EDU-2105-Update-JWT-and-token-auth-examples-to-use-Ably-demo-endpoint branch from 8c5fdc3 to 2fd278a Compare January 21, 2026 11:08
@GregHolmes GregHolmes removed the DRAFT Draft PR - do not review label Jan 21, 2026
@GregHolmes GregHolmes requested a review from a team January 23, 2026 07:48
@GregHolmes GregHolmes added review-app Create a Heroku review app and removed review-app Create a Heroku review app labels Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GregHolmes GregHolmes

Labels

review-app Create a Heroku review app

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GregHolmes @ably-ci