-
Notifications
You must be signed in to change notification settings - Fork 46
[AIT-304] feat: Mutable messages ably-java #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
47bbd5b to
bcbe1e9
Compare
bcbe1e9 to
708610a
Compare
708610a to
c25a14b
Compare
c25a14b to
0940436
Compare
0940436 to
0a7f5c6
Compare
0a7f5c6 to
43cb932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds Ably Java documentation for mutable (updatable/deletable/appendable) messages across the “Updates & deletes” guide and the REST/Realtime Channels API reference.
Changes:
- Adds Java code examples to the updating/deleting/appending and retrieval sections in
updates-deletes.mdx. - Extends REST and Realtime Channels API reference docs with Java method signatures for mutable-message APIs.
- Fixes a corrupted Node.js example line in REST Channels docs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| src/pages/docs/messages/updates-deletes.mdx | Adds Java usage examples for update/delete/append and message retrieval/version APIs. |
| src/pages/docs/api/rest-sdk/channels.mdx | Adds Java signatures/sections for mutable message APIs and fixes a Node.js snippet typo. |
| src/pages/docs/api/realtime-sdk/channels.mdx | Adds Java signatures/sections for mutable message APIs in Realtime Channel docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
43cb932 to
2929b17
Compare
2929b17 to
345d08a
Compare
345d08a to
0895eb0
Compare
b33f69e to
75335ee
Compare
| Returns a promise which, upon success, will be fulfilled with a [`Message`](/docs/api/realtime-sdk/messages) object representing the latest version of the message. Upon failure, the promise will be rejected with an [`ErrorInfo`](/docs/api/realtime-sdk/types#error-info) object which explains the error. | ||
| </If> | ||
|
|
||
| <If lang="java"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <If lang="java"> | |
| <If lang="java,kotlin"> |
If kotlin snippet is same as java, then we can share them right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do in other PR, kotlin syntax a bit different
75335ee to
5d72d36
Compare
5d72d36 to
96ccdca
Compare
Description
Add Mutable messages ably-java
Checklist