[AIT-255] LiveObjects: fix events emitted upon sync #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
AIT-255-fix-replace-data-events
branch
from
2a53268 to
ae32ba3
Compare
lawrence-forooghian
force-pushed
the
AIT-255-fix-replace-data-events
branch
from
ae32ba3 to
3f86319
Compare
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jan 16, 2026
This implements the changes spec from [1] at 3f86319. That is, the update events emitted by a sync are now calculated from the before/after diff of the object state, as opposed to just being calculated from the createOp. Written by Claude based on the spec. [1] ably/specification#414
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jan 16, 2026
This implements the spec changes from [1] at 3f86319. That is, the update events emitted by a sync are now calculated from the before/after diff of the object state, as opposed to just being calculated from the createOp. Written by Claude based on the spec. [1] ably/specification#414
lawrence-forooghian
added a commit
to ably/ably-liveobjects-swift-plugin
that referenced
this pull request
Jan 16, 2026
This implements the spec changes from [1] at 3f86319. That is, the update events emitted by a sync are now calculated from the before/after diff of the object state, as opposed to just being calculated from the createOp. Written by Claude based on the spec. [1] ably/specification#414
VeskeR
approved these changes
Jan 22, 2026
Contributor
VeskeR
left a comment
VeskeR
left a comment
There was a problem hiding this comment.
Looks great, thank you!
I like the simplified version too, that's a nice observation re considering only non-tombstone properties.
Written by Claude based on JS at 194aed7 (i.e. the commit into which the path-based API was merged in a9aea33).
lawrence-forooghian
force-pushed
the
AIT-255-fix-replace-data-events
branch
from
3f86319 to
37220d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written by Claude based on JS at ably/ably-js@194aed7 (i.e. the commit into which path-based API was merged in ably/ably-js@a9aea33).
Note: There are two commits here. The first contains an direct translation of the JS code, the second is functionally equivalent but IMO easier to understand. See which you prefer (my preference is the latter) and I'll then rebase accordingly.