Skip to content

Conversation

@zChanges
Copy link
Contributor

@zChanges zChanges commented Jan 20, 2026

未设置 min max Date 会导致导航切上下年及月按钮不可见。调整为不设置不限制
image

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Resolved an issue with date picker navigation availability checks when availability parameters are not specified.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: 19b77e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alauda/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Walkthrough

The changes introduce a guard condition in the date picker's navigation availability logic to handle cases where no availability window is defined. When availValue is falsy, navigation now displays by default. A changeset entry documents the patch release and related fix, with minor formatting adjustments applied to ternary expressions for consistency.

Changes

Cohort / File(s) Summary
Date picker nav availability fix
src/date-picker/calendar/header/component.ts
Added guard in shouldShowNav to return true when availValue is falsy, handling undefined availability windows. Minor formatting adjustments to ternary expressions.
Release metadata
.changeset/big-apricots-punch.md
Changeset entry for patch release documenting "date picker nav availability check" fix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A guard to catch the missing date,
When nav availability's not there to wait,
True by default, safe and sound,
Now the calendar's logic's tightly wound!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: date picker nav availability check' directly and clearly describes the main change in the pull request, which is fixing how date picker navigation button availability is determined when min/max dates are not set.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 markdownlint-cli2 (0.18.1)
.changeset/big-apricots-punch.md

markdownlint-cli2 v0.18.1 (markdownlint v0.38.0)
Finding: .changeset/big-apricots-punch.md
Linting: 1 file(s)
Summary: 0 error(s)
Error: EACCES: permission denied, open '/markdownlint-cli2-results.json'
at async open (node:internal/fs/promises:640:25)
at async Object.writeFile (node:internal/fs/promises:1214:14)
at async Promise.all (index 0)
at async outputSummary (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:877:5)
at async main (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:1053:25)
at async file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2-bin.mjs:12:22 {
errno: -13,
code: 'EACCES',
syscall: 'open',
path: '/markdownlint-cli2-results.json'
}


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fengtianze fengtianze merged commit 7e3f546 into master Jan 20, 2026
7 checks passed
@fengtianze fengtianze deleted the fix/date-picker-nav-availability-check branch January 20, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants