Skip to content

include: install compress_ops.h as public header #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mpratyus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

include: install compress_ops.h as public header #30

mpratyus wants to merge 1 commit into from
+2 −2

Conversation

@mpratyus
Copy link

@mpratyus mpratyus commented Jan 20, 2026

Move tinycompress/compress_ops.h from noinst_HEADERS to nobase_include_HEADERS so it gets installed for users.

@mpratyus
include: install compress_ops.h as public header
2db4ee4 
Move tinycompress/compress_ops.h from noinst_HEADERS to
nobase_include_HEADERS so it gets installed for users.

Signed-off-by: Pratyush Meduri <mpratyus@qti.qualcomm.com>
@vinodkoul
Copy link
Contributor

vinodkoul commented Jan 21, 2026

thanks for the change.
Can you please give reasons for this change? Why should we move this header for users to care about. Please provide motivation for the change.

@mpratyus
Copy link
Author

mpratyus commented Jan 21, 2026

The motivation for this change is to make compress_ops.h available to external users and plugins that need to implement or register compress offload backends, rather than using tinycompress purely as a client library.
Currently, compress_ops.h is marked as noinst_HEADERS, which limits it to internal use within tinycompress itself. However, the header defines the struct compress_ops interface, which is required by some of our software components that implement their own compress backends and need to integrate with tinycompress using the same ABI and data structures.

perexg added a commit to perexg/tinycompress that referenced this pull request Jan 21, 2026
@perexg
compress_hw: fix formatting (compress_hw_avail64_from_32)
7e53d57 
Link: alsa-project#30
Fixes: 72dd4bb ("compress_hw_get_hpointer: use SNDRV_COMPRESS_AVAIL64")
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg added a commit to perexg/tinycompress that referenced this pull request Jan 21, 2026
@perexg
compress_ops: add magic and look for compress_plugin_mops symbol
9f5f8cc 
We need more validation of passed ops structure to allow
further API changes in future.

This change looks for compress_plugin_mops symbol in the
dynamic plugin library to make sure that the new magic
and new get_tstamp64 members are handled correctly.

Link: alsa-project#29
Link: alsa-project#30
Fixes: 0bd5530 ("compress_ops: add get_tstamp64")
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@perexg perexg mentioned this pull request Jan 21, 2026
Open
@perexg
Copy link
Member

perexg commented Jan 21, 2026

I put some ideas to improve ops API to #31 before we make this header public.

And yes, there is populate_compress_plugin_ops() function which tries to load and use external plugins on demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpratyus @vinodkoul @perexg