Check gcloud context_aware/use_client_certificate for mTLS #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented an additional check for mTLS client certificate usage.
Modified
google/auth/_cloud_sdk.py:get_context_aware_use_client_certificate()to querygcloud config get context_aware/use_client_certificate.Modified
google/auth/transport/_mtls_helper.py:check_use_client_cert()to call the new_cloud_sdkhelper if other checks (environment variables) do not result inTrue.Added/Updated Tests:
tests/test__cloud_sdk.py: Added tests forget_context_aware_use_client_certificate.tests/transport/test__mtls_helper.py: Updated tests to cover the new fallback logic and mock the gcloud check.PR created automatically by Jules for task 16361868464918155708 started by @amtk3