Skip to content

Conversation

@czy006
Copy link
Contributor

@czy006 czy006 commented Jan 16, 2026

[Improvement]: MaintainerMetrics Unified interface and Report (#4034)

Why are the changes needed?

Close #4034 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 26.76768% with 145 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.53%. Comparing base (cbdc517) to head (3eb329e).
⚠️ Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...ats/iceberg/maintainer/IcebergTableMaintainer.java 11.53% 136 Missing and 2 partials ⚠️
...org/apache/amoro/maintainer/MaintainerMetrics.java 25.00% 6 Missing ⚠️
...ache/amoro/maintainer/MaintainerOperationType.java 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4045      +/-   ##
============================================
+ Coverage     22.12%   22.53%   +0.40%     
- Complexity     2461     2570     +109     
============================================
  Files           445      459      +14     
  Lines         40897    42239    +1342     
  Branches       5767     5924     +157     
============================================
+ Hits           9050     9520     +470     
- Misses        31089    31902     +813     
- Partials        758      817      +59     
Flag Coverage Δ
trino 22.53% <26.76%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: MaintainerMetrics Unified interface and Report

2 participants