Feature/769 libuv package and thread header #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnoltes
commented
Jan 18, 2026
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
==========================================
+ Coverage 91.43% 91.50% +0.06%
==========================================
Files 234 235 +1
Lines 28655 28686 +31
==========================================
+ Hits 26200 26248 +48
+ Misses 2455 2438 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I will finish reviewing this weekend. |
PengZheng
reviewed
Jan 25, 2026
PengZheng
reviewed
Jan 25, 2026
libs/utils/CMakeLists.txt
Outdated
| find_package(libuv REQUIRED) | ||
|
|
||
| if (NOT TARGET libuv::uv AND TARGET uv) | ||
| #Note: conan libuv package 1.49.2 defines uv target, but 1.51.0 defines libuv::uv target |
Contributor
There was a problem hiding this comment.
Using latest conan 1.x is OK, thus this hack can be removed.
Let update our conan 1.x all to the latest.
Contributor
There was a problem hiding this comment.
Running conan1 gives the following notice:
WARN: **************************************************
WARN: *** Conan 1 is legacy and on a deprecation path **
WARN: *********** Please upgrade to Conan 2 ************
WARN: **************************************************
I think it's time to get rid of Conan 1.x.
PengZheng
reviewed
Jan 25, 2026
PengZheng
reviewed
Jan 25, 2026
PengZheng
approved these changes
Jan 25, 2026
Contributor
PengZheng
left a comment
PengZheng
left a comment
There was a problem hiding this comment.
Nice addition! LGTM
I left some minor remarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the libuv dependency and creates initial celix_uv_cleanup.h and tests.
Follow up PRs will replace celix_threads.h usage with libuv variants.