-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CKS: Add image store validation for Kubernetes version registration #12418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
CKS: Add image store validation for Kubernetes version registration #12418
Conversation
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12418 +/- ##
=========================================
Coverage 16.23% 16.24%
- Complexity 13382 13388 +6
=========================================
Files 5657 5657
Lines 498999 499020 +21
Branches 60566 60572 +6
=========================================
+ Hits 81035 81051 +16
- Misses 408928 408930 +2
- Partials 9036 9039 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java
Outdated
Show resolved
Hide resolved
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16374 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16384 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
When registering a CKS data ISO for all zones, if any zone lacks secondary storage, the registration fails but leaves an orphaned ISO in zones that do have storage. This requires manual cleanup.
Fixes: #10994
This PR adds upfront validation to check that secondary storage exists before attempting to register the ISO:
Fixes: #10994
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
N/A
How Has This Been Tested?
validateImageStoreForZonemethod.