-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI: fix issues when deploy VNF applicance on network with SG #12436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12436 +/- ##
============================================
- Coverage 16.23% 16.23% -0.01%
- Complexity 13378 13379 +1
============================================
Files 5657 5657
Lines 498971 499025 +54
Branches 60561 60562 +1
============================================
+ Hits 81032 81033 +1
- Misses 408905 408957 +52
- Partials 9034 9035 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
This reverts commit a566af3.
Description
since #9415 , shared network with Security groups are supported in advanced zone (with SG)
This PR fixes two issues when deploy VNF appliance on such network
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?