fix: remove dead code for 0.8/0.9 docs that broke CI #3264
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs/source/user-guide/0.8 and 0.9 directories were removed in commit 6a2209d, but build.sh still had `rm` commands trying to delete files from those directories. With `set -e`, these failing commands caused the docs build to exit with code 1. Removed the dead code since versions 0.8 and 0.9 are no longer generated by generate-versions.py. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
docs/build.shthat was trying to delete files from non-existent directoriesThe
docs/source/user-guide/0.8and0.9directories were removed in commit 6a2209d, butbuild.shstill hadrmcommands trying to delete files from those directories. Withset -eat the top of the script, these failingrmcommands caused the entire docs build to exit with error code 1.The
2> /dev/nullonly suppresses stderr but doesn't prevent the non-zero exit code from terminating the script.Test plan
🤖 Generated with Claude Code