-
Notifications
You must be signed in to change notification settings - Fork 487
[flink] Delta Join additional IT tests and docs improvement #2268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[flink] Delta Join additional IT tests and docs improvement #2268
Conversation
|
@xuyangzhong @wuchong |
ac23b6b to
6035422
Compare
|
Hi, @fresh-borzoni I'm a bit busy these days, I'll try my best to take a look after next Wednesday |
xuyangzhong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for driving this! I have added some comments. Furthermore, some methods for table creation could be reused.
...nk/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/source/Flink22TableSourceITCase.java
Outdated
Show resolved
Hide resolved
...nk/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/source/Flink22TableSourceITCase.java
Outdated
Show resolved
Hide resolved
...nk/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/source/Flink22TableSourceITCase.java
Outdated
Show resolved
Hide resolved
...nk/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/source/Flink22TableSourceITCase.java
Outdated
Show resolved
Hide resolved
...nk/fluss-flink-2.2/src/test/java/org/apache/fluss/flink/source/Flink22TableSourceITCase.java
Outdated
Show resolved
Hide resolved
|
@xuyangzhong Thank you for the review! |
4048bcf to
790959f
Compare
Purpose
Linked issue: close #2231
Add comprehensive test coverage for Delta Join feature in Flink 2.2 and improve documentation.
Brief change log
table.delete.behavior=IGNORE(not justfirst_rowmerge engine)Tests
testDeltaJoinWithPrimaryKeyTableNoDeletes- normal PK table withdelete.behavior=IGNOREtestDeltaJoinOnBucketKey- join on bucket key onlytestDeltaJoinFailsWhenFilterOnNonUpsertKeys- filter on non-upsert-key columns failstestDeltaJoinOnBucketKey- join on bucket key only (not full PK)testDeltaJoinFailsWhenSourceHasDelete- source with DELETE records failstestDeltaJoinFailsWhenJoinKeyNotContainIndex- join key not containing index failtestDeltaJoinFailsWithLeftJoin- LEFT JOIN wouldn't be converted to DeltaJointestDeltaJoinFailsWithRightJoin- RIGHT JOIN wouldn't be converted to DeltaJointestDeltaJoinFailsWithFullOuterJoin- FULL OUTER JOIN wouldn't be converted to DeltaJointestDeltaJoinFailsWithCascadeJoin- cascade join wouldn't be converted to DeltaJoinAPI and Format
No
Documentation
Yes - updated
docs/engine-flink/delta-joins.mdin Flink 2.2 part.