[KV] Kvstore snapshot queries #2409
Conversation
| } | ||
| } | ||
|
|
||
| public void startKeepAlivePeriodically(int keepAliveIntervalMs) { |
There was a problem hiding this comment.
Where do we plan to start to start keepalives? This method seems currently unused.
Separately, I wonder if we're giving clients too much control over holding server resources with keepalives. I can see issue where clients forget to close and server starts leaking iterators.
Should we simplify and get rid of keepalives and refresh iterator TTL on server side whenever a ScanKvRequest is made?
It's a two-way door to release this feature without keepalive. We cannot easily remove keepalive mechanism once added as it would break clients who rely on keepalive mechanism.
| * Creates a new {@link SnapshotQuery} for this table to configure and execute a snapshot query | ||
| * to read all current data in a table bucket (requires to be a Primary Key Table). | ||
| */ | ||
| SnapshotQuery newSnapshotQuery(); |
There was a problem hiding this comment.
Nit: SnapshotQuery sounds like querying an existing snapshot. I cannot think of any name though.. maybe just Query?
2 participants
No description provided.