Skip to content

Conversation

@shuwenwei
Copy link
Member

@shuwenwei shuwenwei commented Jan 28, 2026

Description

When writes occur between the prepare phase and actual query execution, TVList sorting may include newly written rows and increase the row count.If the query continues to use the stale queryRowCount captured during prepare, bitmap construction may access out-of-bounds indices. This change refreshes the rowCount after sorting and ensures bitmap operations use the updated value.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.19%. Comparing base (5802fa2) to head (478e9ec).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...otdb/db/utils/datastructure/BackAlignedTVList.java 0.00% 1 Missing ⚠️
...iotdb/db/utils/datastructure/BackBinaryTVList.java 0.00% 1 Missing ⚠️
...otdb/db/utils/datastructure/BackBooleanTVList.java 0.00% 1 Missing ⚠️
...iotdb/db/utils/datastructure/BackDoubleTVList.java 0.00% 1 Missing ⚠️
.../iotdb/db/utils/datastructure/BackFloatTVList.java 0.00% 1 Missing ⚠️
...he/iotdb/db/utils/datastructure/BackIntTVList.java 0.00% 1 Missing ⚠️
...e/iotdb/db/utils/datastructure/BackLongTVList.java 0.00% 1 Missing ⚠️
...tdb/db/utils/datastructure/QuickAlignedTVList.java 0.00% 1 Missing ⚠️
...otdb/db/utils/datastructure/QuickBinaryTVList.java 0.00% 1 Missing ⚠️
...tdb/db/utils/datastructure/QuickBooleanTVList.java 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17098      +/-   ##
============================================
+ Coverage     39.18%   39.19%   +0.01%     
  Complexity      282      282              
============================================
  Files          5128     5128              
  Lines        343172   343169       -3     
  Branches      43764    43762       -2     
============================================
+ Hits         134459   134495      +36     
+ Misses       208713   208674      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97 JackieTien97 merged commit 11054f9 into master Jan 28, 2026
30 of 31 checks passed
@JackieTien97 JackieTien97 deleted the fixMemTableConcurrentQueryWriteBug branch January 28, 2026 09:38
shuwenwei added a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants