testing/drivers/crypto/hmac.c: Add long keys #3376
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds 2 tests, which include keys that are longer than the SHA's block size. Signed-off-by: Vlad Pruteanu <pruteanuvlad1611@yahoo.com>
PruteanuVlad
force-pushed
the
test_hmac_long_keys
branch
from
077db9f to
6479c12
Compare
xiaoxiang781216
approved these changes
Jan 24, 2026
cederom
approved these changes
Jan 24, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @PruteanuVlad :-)
Lets just make sure CI completes fine :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds 2 cases to the HMAC driver test. They are taken from RFC4231 - Identifiers and Test Vectors for HMAC-SHA-224, HMAC-SHA-256, HMAC-SHA-384, and HMAC-SHA-512, test cases number 6 and 7.
Results for MD5 and SHA1, which aren't included in the RFC were generated using this online calculator, which was validated by checking it's SHA256 against the expected RFC result.
Impact
This update improves the test by covering an additional edge-case.
Testing
Development was done using ESP32 DevkitC.
Building was done on Ubuntu 24.04 VM.
Testing using current nuttx master branch, bug described in this PR present:
Testing using the above mentioned PR fix: