testing/ostest: Fix uninitialized variable warning in wdog test #3377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix compiler warning about uninitialized variable in the watchdog test. The
flagsvariable inwdtest_rand()was not initialized and could trigger-Werror=maybe-uninitializederror on certain architectures (e.g., x86_64/intel64) where the compiler detects potential use before assignment.should merge before apache/nuttx#18135
Changes
File: testing/ostest/wdog.c
flagsvariable to 0 at declarationRoot cause:
The
flagsvariable is conditionally assigned only whencnt % 2is true, but the compiler cannot determine at compile time that the correspondingleave_critical_section(flags)will only be called when the variable was actually assigned.