-
Notifications
You must be signed in to change notification settings - Fork 521
[SYSTEMDS-3779] Add ColGroupDDCLZW with LZW-compressed MapToData #2398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
florian-jobs
wants to merge
25
commits into
apache:main
Choose a base branch
from
LukaDeka:ColGroupDDCLZW2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,626
−14
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ee9e94f
Second skeleton for ColGroupDDCLZW using the IMapToDataInterface and …
florian-jobs 007611c
Idea:
florian-jobs b1bf906
More TODOS written and cleaned up project.
florian-jobs 8027458
Dictionary initialisierung für Compress und rudimentäre Implementieru…
ef3b834
Uebersichtlichkeit verbessert
9886821
Minor error fixing. Redesigned compress method.
florian-jobs e0d5d75
Added red/write methods to serialize and deserialize from stream.
florian-jobs beb4613
Commented code, error handling for compress. next step make compress …
florian-jobs 620e03a
Added first stages of tests. improved compression and decompression a…
florian-jobs b7911d7
Added convertToDDCLZW() method to ColGroupDDC Class. Added convertToD…
florian-jobs 1dfe91e
Started working on ColGroupDDCLZW's other methods that need to be imp…
florian-jobs 3156863
test commit
florian-jobs 10d5776
[SYSTEMDS-3779] Added new Compression and ColGroup Types DDCLZW.
florian-jobs 3c9e2ed
[SYSTEMDS-3779] Introduce initial ColGroupDDCLZW with LZW-compressed …
florian-jobs a8df1fe
Decompression to a specific index
96cb6e9
slice Rows
a30cc91
[SYSTEMDS-3779] Add imemdiate stop after index certain index in decom…
florian-jobs d39fad0
[SYSTEMDS-3779] Reverted formatting of ColGroupDDC,ColGroupDDCLZW,Col…
florian-jobs 9e2cf11
[SYSTEMDS-3779] Intermediate DDCLZW Scheme
7de7f1d
[SYSTEMDS-3779] Added getIdx using LZWMappingIterator. Reverted forma…
florian-jobs 4f3f413
[SYSTEMDS-3779] Fixed out of bounds logic
LukaDeka ca7e6ff
[SYSTEMDS-3779] Added new tests for ColGroupDDCLZW (draft)
LukaDeka ddd2a8b
[SYSTEMDS-3779] Increased sliceRows performance by using iterator. Ad…
florian-jobs a8735e1
Added various fallbacks to ddc for functions with complex access patt…
florian-jobs 72a439b
Added various functions which can be implemented by decoding the lzw …
florian-jobs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1112,13 +1112,13 @@ protected boolean allowShallowIdentityRightMult() { | |
| public AColGroup convertToDeltaDDC() { | ||
| int numCols = _colIndexes.size(); | ||
| int numRows = _data.size(); | ||
|
|
||
| DblArrayCountHashMap map = new DblArrayCountHashMap(Math.max(numRows, 64)); | ||
| double[] rowDelta = new double[numCols]; | ||
| double[] prevRow = new double[numCols]; | ||
| DblArray dblArray = new DblArray(rowDelta); | ||
| int[] rowToDictId = new int[numRows]; | ||
|
|
||
| double[] dictVals = _dict.getValues(); | ||
|
|
||
| for(int i = 0; i < numRows; i++) { | ||
|
|
@@ -1134,13 +1134,13 @@ public AColGroup convertToDeltaDDC() { | |
| prevRow[j] = val; | ||
| } | ||
| } | ||
|
|
||
| rowToDictId[i] = map.increment(dblArray); | ||
| } | ||
|
|
||
| if(map.size() == 0) | ||
| return new ColGroupEmpty(_colIndexes); | ||
|
|
||
| ACount<DblArray>[] vals = map.extractValues(); | ||
| final int nVals = vals.length; | ||
| final double[] dictValues = new double[nVals * numCols]; | ||
|
|
@@ -1153,7 +1153,7 @@ public AColGroup convertToDeltaDDC() { | |
| oldIdToNewId[dac.id] = i; | ||
| idx += numCols; | ||
| } | ||
|
|
||
| DeltaDictionary deltaDict = new DeltaDictionary(dictValues, numCols); | ||
| AMapToData newData = MapToFactory.create(numRows, nVals); | ||
| for(int i = 0; i < numRows; i++) { | ||
|
|
@@ -1162,4 +1162,7 @@ public AColGroup convertToDeltaDDC() { | |
| return ColGroupDeltaDDC.create(_colIndexes, deltaDict, newData, null); | ||
| } | ||
|
|
||
| public AColGroup convertToDDCLZW() { | ||
| return ColGroupDDCLZW.create(_colIndexes, _dict, _data, null); | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks to me the only change in this file is this method convertToDDCLZW, please revert all the formatting only changes. |
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the indentation to tabs again, to avoid changing the DDC base class.