Skip to content

Conversation

@loafoe
Copy link
Contributor

@loafoe loafoe commented Jan 23, 2021

  • Supports HTTP proxies in front of Bastion/Proxy servers
  • Makes this work behind corporate proxies

@codecov-io
Copy link

codecov-io commented Jan 23, 2021

Codecov Report

Merging #63 (e389293) into master (355f45a) will decrease coverage by 24.22%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
- Coverage   83.55%   59.32%   -24.23%     
===========================================
  Files           1        2        +1     
  Lines         225      327      +102     
===========================================
+ Hits          188      194        +6     
- Misses         21      114       +93     
- Partials       16       19        +3     
Impacted Files Coverage Δ
http_proxy.go 0.00% <0.00%> (ø)
easyssh.go 71.32% <16.32%> (-12.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce04db7...e389293. Read the comment docs.

@loafoe
Copy link
Contributor Author

loafoe commented Jan 23, 2021

I wanted to rename the Proxy field to Bastion but this will break compatibility. I hope to improve coverage as well.

@appleboy
Copy link
Owner

I will take look at it. Can you resolve the conflicts?

@loafoe
Copy link
Contributor Author

loafoe commented May 26, 2021

Yep, will look into resolving conflicts shortly

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

❌ Patch coverage is 7.69231% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.32%. Comparing base (e954c88) to head (58f279c).
⚠️ Report is 61 commits behind head on master.

Files with missing lines Patch % Lines
http_proxy.go 0.00% 55 Missing ⚠️
easyssh.go 16.32% 38 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
- Coverage   83.55%   59.32%   -24.23%     
===========================================
  Files           1        2        +1     
  Lines         225      327      +102     
===========================================
+ Hits          188      194        +6     
- Misses         21      114       +93     
- Partials       16       19        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants