Skip to content

Conversation

@nathanalderson
Copy link
Contributor

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

This change builds on #33 by including usage rules for the direct dependencies of all apps in an umbrella project. Previously, only dependencies of the root umbrella project would have their rules included.

@nathanalderson
Copy link
Contributor Author

This probably needs a test, but I haven't taken the time yet to figure out the testing utilities. I can verify that this works on my large umbrella project. Prior to the change, mix usage_rules.sync --list (and, naturally, any generated files) would show only the usage_rules usage rules. It now also includes phoenix, which is used by one of my subprojects:

» mix usage_rules.sync --list

Notices: 

* usage_rules
    usage_rules:otp - has sub-rule
    usage_rules:elixir - has sub-rule
    usage_rules - has usage rules
* phoenix
    phoenix:phoenix - has sub-rule
    phoenix:liveview - has sub-rule
    phoenix:html - has sub-rule
    phoenix:elixir - has sub-rule
    phoenix:ecto - has sub-rule

@nathanalderson nathanalderson marked this pull request as draft October 14, 2025 22:07
@nathanalderson nathanalderson marked this pull request as ready for review October 14, 2025 22:12
@zachdaniel zachdaniel merged commit ab81ac3 into ash-project:main Oct 15, 2025
23 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants